Fix token deletion #7014

julien-f · 2023-09-01T13:43:34Z

DO NOT SQUASH

Forget all connection tokens button should not delete other users' tokens, even when current user is and administrator

Commit
- Title follows commit conventions
- Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
- If bug fix, add Introduced by
Changelog
- If visible by XOA users, add changelog entry
- Update "Packages to release" in CHANGELOG.unreleased.md
PR
- If UI changes, add screenshots
- If not finished or not tested, open as Draft

packages/xo-server/src/xo-mixins/authentication.mjs

So that the behavior is more consistent.

Fixes zammad#17276

julien-f requested a review from pdonias September 1, 2023 13:43

julien-f force-pushed the fix-token-deletion branch from c9d17be to 1046bbd Compare September 1, 2023 13:44

pdonias requested changes Sep 4, 2023

View reviewed changes

packages/xo-server/src/xo-mixins/authentication.mjs Outdated Show resolved Hide resolved

pdonias requested a review from MathieuRA September 4, 2023 08:41

julien-f requested a review from pdonias September 4, 2023 09:43

pdonias approved these changes Sep 4, 2023

View reviewed changes

julien-f added 2 commits September 4, 2023 16:14

feat(xo-server/api): split token.delete to token.deleteOwn

8c09ccb

So that the behavior is more consistent.

fix(xo-web): don't delete other user's auth tokens

f056c35

Fixes zammad#17276

julien-f force-pushed the fix-token-deletion branch from f8253e6 to f056c35 Compare September 4, 2023 14:14

MathieuRA approved these changes Sep 5, 2023

View reviewed changes

julien-f merged commit 750fefe into master Sep 5, 2023
1 check passed

julien-f deleted the fix-token-deletion branch September 5, 2023 08:39

Provide feedback