Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/VM/advanced): VTPM management #7085

Merged
merged 5 commits into from
Oct 19, 2023
Merged

feat(xo-web/VM/advanced): VTPM management #7085

merged 5 commits into from
Oct 19, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Oct 10, 2023 •
edited

Screenshots

Capture d’écran de 2023-10-10 17-27-09
Capture d’écran de 2023-10-10 17-26-07

Description

Can be tested on: 172.16.211.212

See #7066
Spec

Depend of this PR

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Oct 10, 2023
Base automatically changed from xo5/vtmp to master October 12, 2023 07:19
@MathieuRA MathieuRA marked this pull request as ready for review October 12, 2023 07:56
pdonias
pdonias requested changes Oct 12, 2023
View reviewed changes
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA removed the request for review from Pizzosaure October 16, 2023 14:59
MathieuRA and others added 2 commits October 16, 2023 17:05
@MathieuRA @pdonias
Update packages/xo-web/src/common/intl/messages.js
292afe2 
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
@MathieuRA
Pierre's feedback
8aa7ac9
@pdonias pdonias merged commit 1a1dd05 into master Oct 19, 2023
1 check passed
@pdonias pdonias deleted the xo5/vtpm-advanced-settings branch October 19, 2023 13:46
pdonias pushed a commit that referenced this pull request Oct 19, 2023
@MathieuRA
feat(xo-server/xo-web/VM/new): VTPM creation (#7077)
8834af6 
See #7066
See #6802
See #7085
@pdonias pdonias mentioned this pull request Oct 19, 2023
Closed
@MathieuRA MathieuRA mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

@Pizzosaure Pizzosaure Pizzosaure approved these changes

Assignees

@MathieuRA MathieuRA

Labels
comp: GUI 🎨 Highlight XCP-ng 8.3 release 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MathieuRA @pdonias @Pizzosaure @olivierlambert