Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/XOSTOR): warn if replication count is higher than number of hosts with disks #7625

Merged
merged 9 commits into from
May 6, 2024
Merged

feat(xo-web/XOSTOR): warn if replication count is higher than number of hosts with disks #7625

merged 9 commits into from
May 6, 2024

Conversation

Pizzosaure
Copy link
Contributor

Description

Screenshot from 2024-05-02 11-42-56

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@Pizzosaure Pizzosaure requested a review from MathieuRA May 2, 2024 10:09
@Pizzosaure Pizzosaure marked this pull request as ready for review May 2, 2024 10:09
MathieuRA
MathieuRA previously requested changes May 3, 2024
View reviewed changes
packages/xo-web/src/xo-app/xostor/new-xostor-form.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias May 3, 2024 08:45
@Pizzosaure Pizzosaure requested a review from MathieuRA May 3, 2024 12:19
MathieuRA
MathieuRA reviewed May 3, 2024
View reviewed changes
Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add

@Pizzosaure Pizzosaure requested a review from pdonias May 6, 2024 08:24
@pdonias pdonias requested a review from MathieuRA May 6, 2024 08:47
@pdonias pdonias dismissed MathieuRA’s stale review May 6, 2024 09:39

"Nothing to add"

@pdonias pdonias changed the title feat(xo-web/xostor): warn if replication count is higher than number of hosts with disks feat(xo-web/XOSTOR): warn if replication count is higher than number of hosts with disks May 6, 2024
@pdonias pdonias merged commit b9a6651 into master May 6, 2024
1 check passed
@pdonias pdonias deleted the checkReplicationCount branch May 6, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

@MathieuRA MathieuRA Awaiting requested review from MathieuRA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pizzosaure @pdonias @MathieuRA