This repository has been archived by the owner on Nov 28, 2017. It is now read-only.
Modified the scope to use Google profile and email scope instead of the Google Plus scope #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Google Plus scope Check this for reference : https://developers.google.com/+/web/api/rest/oauth In some case, the user won't have a Google Plus profile and the profile.displayName will be empty, which is not really nice if you need to do ACL or remove access to a user. Using the email seems more appropriate since a user can change it's display name, and by doing so, it will create a new XO account.
|
Thanks for your PR :) I don't remember why I choose to use this scope :/ We'll take a look soon! |
|
The only worry I have is for current users of the plugin :/ |
|
Could you just do some plugin configurations (possibility to change the Scopes from Google Plus to Google Account and the XO account name from DisplayName to Email address). Keeping the Google P^lus scope and the DisplayName as default would prevent affecting the current users, but leave some customization for the person like me who wants to use the email address. |
|
Closing in favor of #23 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check this for reference :
https://developers.google.com/+/web/api/rest/oauth
In some case, the user won't have a Google Plus profile and the
profile.displayName will be empty, which is not really nice if you need
to do ACL or remove access to a user. Using the email seems more
appropriate since a user can change it's display name, and by doing so,
it will create a new XO account.