This repository has been archived by the owner on Jul 27, 2021. It is now read-only.
Apply common structure to return value in relayMessages #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When relayMessages process message with kind = 'file' structure of returned message differs from usual (missed fields 'fromTag', 'from', 'kind', 'time'). This solution add required fields and move specific to 'file message' data to field msg.
Now each message on returned message will have same structure:
{
fromTag,
from,
kind: 'type of message',
nonce,
time,
msg: {object specific to given 'kind'}
}
lomchik
requested review from
lord-max and
pavlo-liapin
and removed request for
lord-max and
pavlo-liapin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When relayMessages process message with kind = 'file' structure of returned message differs from usual (missed fields 'fromTag', 'from', 'kind', 'time').
Solution adds required fields and move specific 'file message' data to field msg.
Now each returned message will have same structure:
{ "fromTag": "string", "from": "string", "kind": "type of message", "nonce": "string", "time": 12312312, "msg": "{object specific to given 'kind'}" }