Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONSchemaBridge validator return type #1158

Closed
kestarumper opened this issue Aug 25, 2022 · 0 comments · Fixed by #1172
Closed

JSONSchemaBridge validator return type #1158

kestarumper opened this issue Aug 25, 2022 · 0 comments · Fixed by #1172
Assignees
@kestarumper
Labels
Area: Bridge Affects some of the bridge packages Bridge: JSON Schema Affects the uniforms-bridge-json-schema package Type: Bug Bug reports and their fixes
Milestone
v4.0

Comments

@kestarumper
Copy link
Member

kestarumper commented Aug 25, 2022 •
edited
Loading

Affected versions 3.10.0

Description

In JSONSchemaBridge(schema, validator) the validator function return type is any but the Bridge specifies more concrete type (null | Error | Promise<null | Error>) that can be later returned by the getValidator.

Suggestion

Replace any with null | Error | Promise<null | Error>.
@kestarumper kestarumper added Type: Bug Bug reports and their fixes Area: Bridge Affects some of the bridge packages Bridge: JSON Schema Affects the uniforms-bridge-json-schema package labels Aug 25, 2022
@radekmie radekmie added this to the v3.x milestone Aug 26, 2022
@radekmie radekmie modified the milestones: v3.x, v4.0 Oct 7, 2022
@kestarumper kestarumper mentioned this issue Oct 7, 2022
Merged
@radekmie radekmie moved this to In progress in Open Source Nov 18, 2022
radekmie pushed a commit that referenced this issue Feb 3, 2023
@kestarumper
Improved JSONSchemaBridge validator types (closes #1158).
a43a4a9
@github-project-automation github-project-automation bot moved this from In progress to Closed in Open Source Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kestarumper kestarumper

Labels
Area: Bridge Affects some of the bridge packages Bridge: JSON Schema Affects the uniforms-bridge-json-schema package Type: Bug Bug reports and their fixes
Projects
Open Source
Archived in project
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Improve JSONSchemaBridge validator types vazco/uniforms
2 participants
@radekmie @kestarumper