Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pep257 -> pydocstyle #45

Merged
merged 1 commit into from
Jun 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pep257.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.9']
python-version: ['3.11']

steps:
- uses: actions/checkout@v3
Expand All @@ -26,12 +26,12 @@ jobs:

- name: Install dependencies
run: |
pip install pep257
pip install pydocstyle

- name: source
run: |
python -m pep257 django_admin_geomap
python -m pydocstyle django_admin_geomap

- name: tests
run: |
python -m pep257 --match='.*\.py' tests/test
python -m pydocstyle --match='.*\.py' tests/test
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ static/*
*.sqlite3
.coverage
htmlcov/*
venv/*
venv.*
venv*
build/
dist/
*.egg-info/
2 changes: 1 addition & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -479,4 +479,4 @@ known-third-party=enchant

# Exceptions that will emit a warning when being caught. Defaults to
# "Exception"
overgeneral-exceptions=Exception
overgeneral-exceptions=builtins.Exception
2 changes: 1 addition & 1 deletion django_admin_geomap/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def change_view(self, request, object_id, form_url='', extra_context=None):
return super().change_view(request, object_id, form_url, extra_context=extra_context)

def add_view(self, request, form_url='', extra_context=None):
"""New antenna data at the map."""
"""Add new antenna data at the map."""
return super().add_view(request, form_url, extra_context=self.set_common(request, extra_context))


Expand Down
4 changes: 2 additions & 2 deletions makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ lint:
$(PYLINT) $(SOURCE)

pep257:
$(PYTHON) -m pep257 $(SOURCE)
$(PYTHON) -m pep257 --match='.*\.py' $(TESTS)/test
$(PYTHON) -m pydocstyle $(SOURCE)
$(PYTHON) -m pydocstyle --match='.*\.py' $(TESTS)/test

tests: flake8 pep257 lint static db
$(PYTEST) --durations=5 $(TESTS)
Expand Down
2 changes: 1 addition & 1 deletion tests/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
flake8
pylint
pylint-django
pep257
pydocstyle
pytest
codacy-coverage
pytest-cov