Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "ruler" to "name" and "ruler_detail" to "name_detail" #50

Closed
vbalalian opened this issue Dec 19, 2023 · 0 comments
Closed

Change "ruler" to "name" and "ruler_detail" to "name_detail" #50

vbalalian opened this issue Dec 19, 2023 · 0 comments

Comments

@vbalalian
Copy link
Owner

Incorporating Roman Republican coinage makes the field name "ruler" unsuitable; "name" would be more appropriate. This change will require comprehensive replacement of the field name in web_scraper.py, main.py, test_web_scraper.py, and test_api.py, as well as test_coins.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant