Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test failure: including sha256digest keyword #86

Closed
vbatts opened this issue Nov 11, 2016 · 3 comments
Closed

test failure: including sha256digest keyword #86

vbatts opened this issue Nov 11, 2016 · 3 comments

Comments

@vbatts
Copy link
Owner

vbatts commented Nov 11, 2016

https://travis-ci.org/vbatts/go-mtree/jobs/175124512

go vet ./... && touch .vet
go build ./cmd/gomtree
[0001.sh] Running in /tmp/go-mtree.qvaEFy
~/gopath/src/github.com/vbatts/go-mtree ~/gopath/src/github.com/vbatts/go-mtree
~/gopath/src/github.com/vbatts/go-mtree
[0002.sh] Running in /tmp/go-mtree.cC6opx
~/gopath/src/github.com/vbatts/go-mtree ~/gopath/src/github.com/vbatts/go-mtree
2016/11/11 17:08:59 cannot verify keywords not in mtree specification: sha256digest
make: *** [.cli.test] Error 1
The command "make validation" exited with 2.
@vbatts vbatts changed the title build failure: including sha256digest keyword test failure: including sha256digest keyword Nov 11, 2016
@vbatts
Copy link
Owner Author

vbatts commented Nov 11, 2016

@cyphar something with #48 and #85 being merged around the same time?

@vbatts vbatts mentioned this issue Nov 11, 2016
Merged
@cyphar
Copy link
Contributor

cyphar commented Nov 12, 2016

Yeah, that looks like an error message I wrote. I'll take a look.

@cyphar
Copy link
Contributor

cyphar commented Nov 12, 2016

@vbatts I figured it out. It's because of the unsupported issue I mentioned in #83. If you check that test's manifest it doesn't contain any sha256digest entries which means that CollectUsedKeywords doesn't return it.

We need to have a way of indicating those entries. Maybe we could just prepend /set and /unset at the beginning of each hierarchy?

@cyphar cyphar mentioned this issue Nov 12, 2016
Closed
vbatts added a commit that referenced this issue Nov 18, 2016
@vbatts
*: fix comparison of missing keywords
8f3771f 
Adding another test validated from the FreeBSD workflow.

Just because the keywords requested to be validated are not present in
the manifest, it is not an error.
Also, if the keywords from a new manifest are not present in a prior
manifest, then only compare the common keywords.

Fixes #86

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@vbatts vbatts closed this as completed in 21723a3 Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbatts @cyphar