Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

fix: ts type error #218

Merged
merged 2 commits into from
Oct 27, 2023
Merged

fix: ts type error #218

merged 2 commits into from
Oct 27, 2023

Conversation

pzzyf
Copy link
Contributor

@pzzyf pzzyf commented Oct 26, 2023

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pzzyf
Copy link
Contributor Author

pzzyf commented Oct 26, 2023

我在想改这种小的 可以直接push吗 还有改错别字 如果不能 改10次或者几次 mr一下怎么样

@pzzyf pzzyf requested a review from likui628 October 26, 2023 15:03
@likui628
Copy link
Collaborator

vitejs/vite#9599
你看下这个,glob好像支持泛型的

@pzzyf
Copy link
Contributor Author

pzzyf commented Oct 27, 2023

是我vscode的问题嘛

@@ -7,7 +7,7 @@ export const components = {
/* 上面写法vite官方已弃用,详情见 https://cn.vitejs.dev/guide/migration-from-v2.html#importmetaglob */
const comp = import.meta.glob('./**/*.vue', {eager: true})
Copy link
Collaborator

@likui628 likui628 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const comp = import.meta.glob<any>('./**/*.vue', {eager: true})
这是最简单的方式,我也不确定这里给什么类型合适。
不过这里不太重要。

@likui628 likui628 merged commit ee0bd36 into vbenjs:master Oct 27, 2023
@pzzyf pzzyf deleted the fix/ts branch October 30, 2023 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants