Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

refactor: optimized logic for closing tabs #237

Merged
merged 4 commits into from
Nov 1, 2023
Merged

refactor: optimized logic for closing tabs #237

merged 4 commits into from
Nov 1, 2023

Conversation

likui628
Copy link
Collaborator

@likui628 likui628 commented Nov 1, 2023

General

优化了关闭左侧,右侧,其它标签的逻辑

  1. 修复 标签页操作这里,关闭左右标签并没有按当前标签页的位置来变化 #215 遗留问题
  2. 关闭其它标签是判断当前路由是否还存在,如果不存在则跳转到目标页面或者首页
  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jinmao88 jinmao88 merged commit 4ee5793 into master Nov 1, 2023
@likui628 likui628 deleted the multi-tabs branch November 1, 2023 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants