Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

refactor: move admin/hooks to @vben/hooks #85

Merged
merged 8 commits into from
Sep 8, 2023
Merged

refactor: move admin/hooks to @vben/hooks #85

merged 8 commits into from
Sep 8, 2023

Conversation

likui628
Copy link
Collaborator

@likui628 likui628 commented Sep 7, 2023

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@likui628 likui628 changed the title refactor: move useRootSetting to @vben/hooks WIP: move admin/hooks to @vben/hooks Sep 7, 2023
@likui628 likui628 changed the title WIP: move admin/hooks to @vben/hooks refactor: move admin/hooks to @vben/hooks Sep 8, 2023
@likui628
Copy link
Collaborator Author

likui628 commented Sep 8, 2023

@jinmao88 useLockScreen没法动,依赖的store在@vben/store里不存在

麻烦review一下

@jinmao88 jinmao88 merged commit fb6a4a6 into vbenjs:master Sep 8, 2023
@likui628 likui628 deleted the use-root-setting branch September 8, 2023 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants