Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update unplugin-config #3116

Merged
merged 1 commit into from
Oct 10, 2023
Merged

chore: update unplugin-config #3116

merged 1 commit into from
Oct 10, 2023

Conversation

kirklin
Copy link

@kirklin kirklin commented Oct 9, 2023

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wangjue666
Copy link
Collaborator

@kirklin 哥你这个包升级了啥 能简要说说吗

@kirklin
Copy link
Author

kirklin commented Oct 10, 2023

最大的变化是API设计,也就是Options重构了,暂时不能无缝升级,所以交了个pr,后续应该不太会有这种大重构了。然后多增加了自定义脚本注入位置,以及支持指定环境变量的位置

@wangjue666 wangjue666 merged commit f8698c4 into vbenjs:main Oct 10, 2023
2 checks passed
@wangjue666
Copy link
Collaborator

@kirklin
image 打完包后并没有直接填充进去

@wangjue666
Copy link
Collaborator

image
之前打完包会直接填充

@wangjue666
Copy link
Collaborator

你打开网站也能直观感受到 他会等那个mainjs加载完才会显示出正确的title

@kirklin
Copy link
Author

kirklin commented Oct 10, 2023

image

@wangjue666
Copy link
Collaborator

image

@wangjue666
Copy link
Collaborator

我先回滚下吧, 修好再提个pr好了

wangjue666 added a commit that referenced this pull request Oct 10, 2023
wangjue666 added a commit that referenced this pull request Oct 10, 2023
@kirklin
Copy link
Author

kirklin commented Oct 10, 2023

我大概懂了,vite-plugin-html没办法识别转义后的符号,
原本

<%= VITE_GLOB_APP_TITLE %>

会变成

&lt;%= VITE_GLOB_APP_TITLE %&gt;

@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants