Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search menu now correctly lowercases input keys (resolved in r: 96ac362fa6a89af256cf8a84e4b667c195c6ea2e) #3842

Merged
merged 1 commit into from
May 14, 2024

Conversation

doraemonxxx
Copy link

@doraemonxxx doraemonxxx commented May 14, 2024

In commit 96ac362, I forgot to add the lowercase method for input keys. This omission caused a bug where the menu wouldn't display items if the search letter was capitalized.

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@doraemonxxx doraemonxxx changed the title Fix: search menu now correctly lowercases input keys (resolved in r: 96ac362fa6a89af256cf8a84e4b667c195c6ea2e) fix: search menu now correctly lowercases input keys (resolved in r: 96ac362fa6a89af256cf8a84e4b667c195c6ea2e) May 14, 2024
@wangjue666 wangjue666 merged commit 144cdd4 into vbenjs:main May 14, 2024
2 checks passed
@vbenjs vbenjs locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants