Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useDataSource): BasicTable Component with dataSource is not working (hot fix) #3888

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(useDataSource): BasicTable Component with dataSource is not working (hot fix) #3888

merged 1 commit into from
Jun 4, 2024

Conversation

doraemonxxx
Copy link

@doraemonxxx doraemonxxx commented Jun 3, 2024

Issue: #3887
Reference: fee8081
Demo: https://vben.vvbin.cn/#/comp/table/basic

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@doraemonxxx doraemonxxx changed the title fix(dataSource): (hot fix) BasicTable Component with dataSource is not working fix(dataSource): BasicTable Component with dataSource is not working (hot fix) Jun 3, 2024
@doraemonxxx
Copy link
Author

doraemonxxx commented Jun 3, 2024

Hi Admin,

Please review this revision before merging, as it is a hot fix. I have only tested the <BasicTable :dataSource="data"> manually, not the useTable.

@doraemonxxx doraemonxxx changed the title fix(dataSource): BasicTable Component with dataSource is not working (hot fix) fix(useDataSource): BasicTable Component with dataSource is not working (hot fix) Jun 3, 2024
@wangjue666 wangjue666 merged commit f830024 into vbenjs:main Jun 4, 2024
2 checks passed
@vbenjs vbenjs locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants