-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some File functionality to an intermediate Root class #55
Conversation
I like the idea of making the |
Not sure if it's a good idea to "pollute" Besides, adding You gotta draw the "it stops here" line somewhere :-) All that said, I'm not saying I'm against this, I'm just taking a conservative approach until I think more about this. |
I dont think this a good idea too. Not all Compoud has this meaning. |
@vberlier : The main goal of this PR is to split You can move functionality from For now I really need a Compound subclass that has |
Hey! I'm really sorry I had to take a break to work on other things... Anyway I just rebased this on master and reverted the change to |
BREAKING CHANGE: The Root class is gone and so is the root attribute on files Fixes #145
As discussed in #1 :
Some NBT Compound tags are root tags but are not a file, namely Chunks from a Region File. As such it would be useful for them to have
.root
and.root_name
but not.load()
,.save()
, etc.This PR creates a
Root
class representing such compound tags, inheriting fromCompound
, move some ofFile
functionality to this new class, and changeFile
to inherit fromRoot