Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster all sky image analysis #57

Closed
kuntzer opened this issue Jun 27, 2018 · 7 comments
Closed

Faster all sky image analysis #57

kuntzer opened this issue Jun 27, 2018 · 7 comments
Milestone

Comments

@kuntzer
Copy link
Collaborator

kuntzer commented Jun 27, 2018

For now, it is embarrassingly slow. Find what is causing this and fix it.

@kuntzer kuntzer added this to the v0.4 milestone Jun 27, 2018
@kuntzer kuntzer modified the milestones: v0.4, v0.3 Jun 27, 2018
@kuntzer
Copy link
Collaborator Author

kuntzer commented Jun 27, 2018

It is really slow. Must be fixed for version 0.3

kuntzer added a commit that referenced this issue Jun 29, 2018
@kuntzer
Copy link
Collaborator Author

kuntzer commented Jun 29, 2018

Fixed it by doing less iterations when trying to measure the FWHM of the stars by fitting a Gaussian.

To go even faster, should use other ways of measuring FWHM, but I think it's acceptable now.

@kuntzer kuntzer closed this as completed Jun 29, 2018
@vbonvin
Copy link
Owner

vbonvin commented Jul 6, 2018

I got an error message related to this:

  File "/home/vivien/work/pouet/pouet/clouds.py", line 98, in update
    x, y = self.detect_stars()
  File "/home/vivien/work/pouet/pouet/clouds.py", line 122, in detect_stars
    image /= filters.gaussian_filter(np.nan_to_num(image), 10)
TypeError: unsupported operand type(s) for /: 'NoneType' and 'NoneType'

It worked for a few allsky refreshes and then crashed.

@vbonvin vbonvin reopened this Jul 6, 2018
@kuntzer
Copy link
Collaborator Author

kuntzer commented Jul 6, 2018

that's extremely weird. Do you have more info on this? I'll run pouet for a while and see if I can reproduce

@vbonvin
Copy link
Owner

vbonvin commented Jul 6, 2018 via email

kuntzer added a commit that referenced this issue Jul 10, 2018
@kuntzer
Copy link
Collaborator Author

kuntzer commented Jul 10, 2018

Could not reproduce, added a fail safe at the line in question. It will be considered as an error in the log. Will close this issue for now. Re-open if it happens again.

@kuntzer kuntzer closed this as completed Jul 10, 2018
@vbonvin
Copy link
Owner

vbonvin commented Jul 10, 2018

OK. Same here, didn't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants