Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on bad symbol size in ELF header #354

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Conversation

dthaler
Copy link
Contributor

@dthaler dthaler commented Jun 7, 2022

ELFIO expects symbols to be either 16 bytes (if 32-bit) or 24-byte (if 64-bit)
But it uses the entry size in the header to compute the number of symbols.
In this test file, they don't match, which resulted in a crash before this fix, and an error after it.

Signed-off-by: Dave Thaler dthaler@microsoft.com

@coveralls
Copy link

coveralls commented Jun 7, 2022

Pull Request Test Coverage Report for Build 2455606236

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 70.136%

Files with Coverage Reduction New Missed Lines %
../../../../../usr/include/boost/container/detail/next_capacity.hpp 2 55.56%
Totals Coverage Status
Change from base Build 2452331854: -0.002%
Covered Lines: 5909
Relevant Lines: 8425

💛 - Coveralls

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@elazarg elazarg merged commit c8924be into vbpf:main Jun 7, 2022
@dthaler dthaler deleted the badsymsize branch June 7, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants