-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt launcher for Android #3817
Qt launcher for Android #3817
Conversation
dev docs to be updated |
0114bfa
to
4228967
Compare
Abort message: 'terminating with uncaught exception of type std::runtime_error: Resource with name CONFIG/FILESYSTEM and type JSON wasn't found.' samsung |
android/vcmi-app/src/main/java/eu/vcmi/vcmi/VcmiSDLActivity.java
Outdated
Show resolved
Hide resolved
android/vcmi-app/src/main/java/eu/vcmi/vcmi/VcmiSDLActivity.java
Outdated
Show resolved
Hide resolved
4228967
to
5a170cd
Compare
next build should solve it |
Also add the possibility to add scrolling to the elements: Laserlicht/vcmi@0c236da...2ac85d9 After that the only remaining issue is that after changing the language in setup it's not possible to proceed (error with resizing). And some long texts. |
Nice trick! Will definitely add both changes. |
@@ -88,16 +89,16 @@ jobs: | |||
preset: windows-mingw-conan-linux | |||
conan_profile: mingw32-linux.jinja | |||
- platform: android-32 | |||
os: ubuntu-22.04 | |||
os: macos-14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test change or permanent one?
Github offers more Linux CI runners than macOS runners. Having a lot of macOS runners might slow down CI queue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could provide Qt host tools (all the stuff in bin folder, plus androiddeployqt) for Linux, then we can use Linux builder again.
Was not able to pass initial wizard. First of all language selector is quite laggy. But main problem is file storage. Was not able to upload files there using standard controls. Says can not detect HOMM3 files when I select a folder which previous launcher was able to accept. Maybe copying them manually may work. |
After manually moving files was able to start random map but not campaign. Was not able to use Install GOG Files |
Was not able to start a regular map as well. 2024-04-24 21:20:46.730 25602-25722/? E/libc++abi: terminating with uncaught exception of type std::runtime_error: Failed to find object of type randomResource::object |
#6 pc 0000000000e531a0 /data/app/~~geG1DA1WdRGmf9Cv0LgjYw==/is.xyz.vcmi.daily-2av4AcFJ8wkIA7hvKitSCg==/lib/arm64/libvcmiclient_arm64-v8a.so (VCMI::CObjectClassesHandler::getHandlerFor(std::__ndk1::basic_string<char, std::__ndk1::char_traits, std::__ndk1::allocator > const&, std::__ndk1::basic_string<char, std::__ndk1::char_traits, std::__ndk1::allocator<char |
Daily build from develop works fine. |
5a170cd
to
7e40fb8
Compare
applied all suggestions @nullkiller that was upstream issue |
still need to update dev docs and rename apk to include commit hash / branch name |
Not sure if you've tested it, but there is also |
only signing fails locally because I don't have the key. I've made adjustments to CI, should work I believe. In the worst case let's fix it after upload attempt fails. |
7e40fb8
to
b5e471d
Compare
I also have this problem right now. Manual copy still works. === However if files are copied manually, everything seems to be working as intended! Yeah, some things are not very suitable for touchscreens, and I would tone down that "overshot" effect when you try to scrolling too far, especially on mod list. But these things are quite minor and certainly something we can live with. |
the gog fix made it to the beta branch, should I retarget PR? |
Sure. Don't see any problems with targeting beta, it is not like we have to merge it in 1.5.0 if you do so. But probably won't fix not working "copy existing data" option. |
targetSdkVersion is the reason most probably, thanks! |
googling shows this: testOnly="true" means the APK can only be installed via adb (which Android Studio uses) |
e892307
to
564314b
Compare
let's see if it's fixed, then will remove the temp commit |
Apk installs, but translations are broken? Changing language does nothing. Everything else seems to be working so far |
564314b
to
d1c0ce5
Compare
yeah, sorry, copied fix blindly from #4091 and didn't test it. Reverted it and removed the temp commit. |
Seems to be working. Issues that I've noticed:
Any way to fix/alleviate 1st issue? Progress bar would be great, but even simple "copying data, please wait" message would be better than UI freeze. In any case don't see anything critical. Will try to look into these issues after merge. Perhaps post on Discord and if nothing critical is found - merge tomorrow? |
yes, I already mentioned it above
same on iOS
it's doable, but would need more Java code (and possibly notifying Qt app to show the progress bar / message if we want to display it from Qt) |
Would be great to fix that for 1.5.3. Progress bar would be amazing, but even simple "Copying data, please wait" message will do, whether via Java or via Qt. Can look into rest of issues I've mentioned myself, but probably not this one unfortunately. |
ok, will try to implement that |
Perhaps merge as it and fix UI freeze in separate PR? What do you think? If yes - can you rebase PR to fix that merge conflict? |
Fine for me. Will rebase in the evening. |
also embeds icons and translations as Qt resources instead of reading from disk
affects fetching mods list
d1c0ce5
to
d139d09
Compare
androiddeployqt
assumptionsconfig
andMods
dirs inside the binary and unpacks that at launcher start: this replaces packing them in a zip and unpacking with Java code