Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toneyisnow/fixbug putback artifact #631

Closed

Conversation

@Toneyisnow
Copy link
Contributor

Toneyisnow commented Mar 8, 2020

Fix bug for deselect artifact: when putting artifact back, call treeHasChanged() to update the cached values.
Also update the variables with type TBonusListPtr to auto for better code change in future.

Toneyisnow added 2 commits Feb 7, 2020
Merging code from origin
…hanged() to update the cached values.

Also update the variables with type TBonusListPtr to auto for better code change in future.

(cherry picked from commit 7b3c49cee3c86ac9ef0b80d5ba0d10639134affb)
Toneyisnow added 3 commits Mar 8, 2020
…y the root cause of the issue, but this should make the code more robust since the heroBonuses should be a "const".
alexvins added a commit that referenced this pull request Mar 17, 2020
@alexvins

This comment has been minimized.

Copy link
Member

alexvins commented Mar 17, 2020

I`ve pushed changes from 0a5e163. For me it fixes the issue.

@Toneyisnow

This comment has been minimized.

Copy link
Contributor Author

Toneyisnow commented Mar 18, 2020

Thanks for the review! I'm closing this PR now.

@Toneyisnow Toneyisnow closed this Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.