Toneyisnow/fixbug putback artifact #631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging code from origin
…hanged() to update the cached values. Also update the variables with type TBonusListPtr to auto for better code change in future. (cherry picked from commit 7b3c49cee3c86ac9ef0b80d5ba0d10639134affb)
alexvins
reviewed
Mar 8, 2020
…y the root cause of the issue, but this should make the code more robust since the heroBonuses should be a "const".
alexvins
reviewed
Mar 11, 2020
alexvins
added a commit
that referenced
this pull request
Mar 17, 2020
|
I`ve pushed changes from 0a5e163. For me it fixes the issue. |
|
Thanks for the review! I'm closing this PR now. |
ShubusCorporation
pushed a commit
to ShubusCorporation/vcmi
that referenced
this pull request
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug for deselect artifact: when putting artifact back, call treeHasChanged() to update the cached values.
Also update the variables with type TBonusListPtr to auto for better code change in future.