chore: add additional metrics (websockets / node stats) #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #778 +/- ##
==========================================
- Coverage 62.14% 62.13% -0.01%
==========================================
Files 203 203
Lines 18688 18702 +14
==========================================
+ Hits 11613 11620 +7
- Misses 5975 5980 +5
- Partials 1100 1102 +2 ☔ View full report in Codecov by Sentry. |
paologalligit
previously approved these changes
Jul 10, 2024
api/subscriptions/subscriptions.go
Outdated
| return conn, closed, nil | ||
| paths := strings.Split(req.URL.Path, "/") | ||
| subject := "unknown" | ||
| if len(paths) > 2 { |
There was a problem hiding this comment.
Can you add in a comment the format of the req.URL.Path we expect to receive? Also with an example, so to better understand what that third place element could be
There was a problem hiding this comment.
Pushed that change
otherview
reviewed
Jul 12, 2024
otherview
previously approved these changes
Jul 15, 2024
|
@otherview screenshots of the affected metrics: 
|
otherview
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding metrics around subscriptions and node stats
Please delete options that are not relevant.
How Has This Been Tested?
TODO
Checklist: