Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

account: change instance instead of prototype #40

Merged
merged 2 commits into from
Aug 10, 2018
Merged

Conversation

libotony
Copy link
Member

@libotony libotony commented Aug 9, 2018

fix #38

@codecov-io
Copy link

codecov-io commented Aug 9, 2018

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         519    518    -1     
  Branches      145    145           
=====================================
- Hits          519    518    -1
Impacted Files Coverage Δ
src/extend/accounts.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e4ca3...283dc41. Read the comment docs.

@libotony libotony merged commit 36dc6bf into vechain:master Aug 10, 2018
@libotony libotony deleted the dev branch August 10, 2018 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Extending web3.eth.accounts shouldn't modify it's prototype
2 participants