Fix SSO query params #950
Merged
Fix SSO query params #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SSO is not functional when hydrogen is loaded on a page with a URL containing query parameters (e.g.
http://example.com?foo=bar&bar=baz), as the query parameters get stripped.The query parameters are removed in two places:
redirectUrlparameter, so the resulting URL ishttps://example.com/_matrix/client/r0/login/sso/redirect?redirectUrl=http://example.com.In #911 we made it so that SSO callback URLs containing query parameters are correctly passed to the homeserver. However, we weren't yet actually passing the query parameters, as described above. This PR fixes that, so that:
redirectUrlparameter now contains query parameters, e.g.https://example.com/_matrix/client/r0/login/sso/redirect?redirectUrl=http%3A%2F%2Fexample.com%3Afoo%3Dbar%26bar%3DbazloginTokenquery parameter is stripped upon returning to the page after SSO.