Allow closing room creation and room joining views on small screens

[psrpinto]

Fixes #903 #904 #936

When hydrogen is in "single-column" mode (i.e. small screen), entering certain views related to creating or joining a room makes it impossible for the user to exit that view.

The user could use the browser back button of course, but in situations where that is not possible (e.g. when hydrogen is being rendered in an iframe), the user will be locked in that screen. The only solution out of it is to delete local storage.

For consistency with other views, I think it would make sense to allow the user to go back using the same mechanism they use in other views, i.e. the back button on the view header.

Signed-off-by: Paulo Pinto paulo.pinto@automattic.com

Screen captures

Before	After

[thigg]

Does this fully supersede #937 ?
Related issues #903 #904 #936?

[thigg]

No it looks like #904 is not solved by this yet. Maybe add this page as well?

Anyway thanks for doing this more cleanly than i in #937 :)

[psrpinto]

Oops, I didn't realize there was already a PR for this, apologies @thigg. I'm happy to close this in favour of #937 if you think that makes sense, though I think the changes here that add the JoinRoomView, JoinRoomView_body and JoinRoomView_header classes do make sense.

If we keep this instead of #937 I'm happy to also address #904 here. For now I'm moving this to draft.

[thigg]

#937 is really dirty. I'd favor yours! Am Dienstag, 20. Dezember 2022 schrieb Paulo Pinto:

…

Oops, I didn't realize there was already a PR for this, apologies @thigg. I'm happy to close this in favour of #937 if you think that makes sense, though I think the changes here that add the `JoinRoomView`, `JoinRoomView_body` and `JoinRoomView_header` do make sense. If we keep this instead of #937 I'm happy to also address #904 here. For now I'm moving this to draft. -- Reply to this email directly or view it on GitHub: #951 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***

-- Gesendet von meinem Sailfish Gerät

[psrpinto]

@thigg I've now addressed #904 here as well, and updated the PR description and screen captures accordingly.

[thigg]

Very cool. I hope this will be merged for the next release!

[thigg]

@MidhunSureshR do you think this could make it to thw next release? This is quite a showstopper in some cases.

Let us know if more needs to be done before merging.

[MidhunSureshR]

Yes, this will surely be in the next release 👍

[MidhunSureshR]

@psrpinto Can you sign-off on this PR so that I can merge it?

[psrpinto]

Now signed-off the PR @MidhunSureshR

[thigg]

Yes, this will surely be in the next release +1

@MidhunSureshR can this be in the next release? ;)