enhancement(journald source): Add received and invalid line events #3241
Conversation
Signed-off-by: Bruce Guenter <bruce@timber.io>
bruceg
added
type: enhancement
| pub text: String, | ||
| } | ||
|
|
||
| impl InternalEvent for JournaldInvalidRecord { |
There was a problem hiding this comment.
@lukesteensen you would know better. But do we want errors to end with *Error? So JournaldInvalidRecordError?
There was a problem hiding this comment.
The precedent is to not, and just make the event name obvious: ElasticSearchMissingKeys, KubernetesLogsEventAnnotationFailed, RegexFailedMatch, etc
There was a problem hiding this comment.
Got it. I do think we should standardize around naming rules sooner than later. I'm poking at this because I would like to derivce documentation from these structures in some way. But that's outside of the scope of this PR right now.
There was a problem hiding this comment.
I don't think it's as simple as all of these being considered errors, so the naming convention now is just precisely what happened.
Signed-off-by: Bruce Guenter <bruce@timber.io>
…ectordotdev#3241) Signed-off-by: Bruce Guenter <bruce@timber.io> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Signed-off-by: Bruce Guenter bruce@timber.io
Closes #3200
Are there other events that would be worth adding, like counting batches or lines before filtering?