Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(observability): Add internal events for http source #3264

Merged
merged 5 commits into from
Aug 4, 2020
Merged

enhancement(observability): Add internal events for http source #3264

merged 5 commits into from
Aug 4, 2020

Conversation

juchiast
Copy link
Contributor

@juchiast juchiast commented Jul 30, 2020 •
edited
Loading

closes #3199

Added HTTPEventsReceived and HTTPBadRequest.

@juchiast
Add internal events for HTTP source
5e8170f 
Signed-off-by: Duy Do <juchiast@gmail.com>
@juchiast
Rename event
53c6a53 
Signed-off-by: Duy Do <juchiast@gmail.com>
@fanatid fanatid added domain: observability Anything related to monitoring/observing Vector source: http_server Anything `http_server` source related labels Jul 30, 2020
@bruceg bruceg mentioned this pull request Jul 30, 2020
Closed
@juchiast
Remove Error in name
7e67341 
Signed-off-by: Duy Do <juchiast@gmail.com>
@juchiast
debug! -> trace!
675c2e4 
Signed-off-by: Duy Do <juchiast@gmail.com>
@binarylogic binarylogic self-requested a review July 31, 2020 16:01
binarylogic
binarylogic approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@binarylogic binarylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@juchiast juchiast merged commit 059e160 into master Aug 4, 2020
@juchiast juchiast deleted the juchiast/http-source-internal-events branch August 4, 2020 14:36
@ktff ktff mentioned this pull request Aug 5, 2020
Merged
1 task
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
@juchiast
enhancement(observability): Add internal events for http source (ve…
6c99032 
…ctordotdev#3264)

* Add internal events for HTTP source

Added HTTPEventsReceived and HTTPBadRequest.

Signed-off-by: Duy Do <juchiast@gmail.com>
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binarylogic binarylogic binarylogic approved these changes

@fanatid fanatid fanatid approved these changes

Assignees

@juchiast juchiast

Labels
domain: observability Anything related to monitoring/observing Vector source: http_server Anything `http_server` source related
Projects
None yet
Milestone
2020.08.03 - Observability Bonanza
Development

Successfully merging this pull request may close these issues.

Define events for the http source
3 participants
@juchiast @binarylogic @fanatid