Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(vrl): support standalone key encoding in encode_key_value #7951

Merged

Conversation

prognant
Copy link
Contributor

@prognant prognant commented Jun 21, 2021

Allow :

{
"k1": "v1",
"k2": true,
"k3": false
}

to be serialised as:
k1=v1 k2

See here for this logfmt "extension"

@prognant prognant marked this pull request as draft June 21, 2021 10:00
@prognant prognant changed the title enhancement(remap): support standalone key encoding in encode_key_value enhancement(vrl): support standalone key encoding in encode_key_value Jun 21, 2021
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@prognant prognant marked this pull request as ready for review June 22, 2021 07:46
@prognant prognant requested review from a team and pablosichert and removed request for a team June 22, 2021 07:46
Base automatically changed from prognant/vrl-add-ddog-tag to master June 22, 2021 08:49
…lue`

Signed-off-by: prognant <pierre.rognant@datadoghq.com>
Signed-off-by: prognant <pierre.rognant@datadoghq.com>
@prognant prognant force-pushed the prognant/vrl-boolean-value-flattening-in-encode_key_value branch from 0efb304 to 8594a4d Compare June 22, 2021 09:05
@prognant
Copy link
Contributor Author

prognant commented Jun 22, 2021

#7751 has been merged into master this one should be good to go on top of it.

@prognant prognant enabled auto-merge (squash) June 22, 2021 09:08
@prognant prognant merged commit 9daa0bd into master Jun 22, 2021
@prognant prognant deleted the prognant/vrl-boolean-value-flattening-in-encode_key_value branch June 22, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants