enhancement: Expand usage of resolve_constant and add support for variables
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pront
approved these changes
Jul 7, 2023
| @@ -20,22 +20,27 @@ impl Query { | |||
| // TODO: | |||
| // - error when trying to index into object | |||
| // - error when trying to path into array | |||
| #[must_use] | |||
There was a problem hiding this comment.
Perhaps it's better to apply #[must_use] to the struct Query.
There was a problem hiding this comment.
Does that mean the same thing? These were from clippy suggestions (I'm not sure why it wanted it on these functions all of a sudden)
There was a problem hiding this comment.
I tried it, unfortunately clippy starts complaining if I only put it on the struct itself 😞
There was a problem hiding this comment.
Ah I see, thanks for trying it out. This might happen because std::hint::must_use is still experimental.
spencergilbert
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #151
closes: #114
Expr::resolve_constanttries to resolve an expression with only compile-time information. This implementation has been improved to also resolve variables if the value of the variable is known at compile-time.This is something that is useful for
ArgumentListfunctions, such asArgumentList::required_regex, so for example a variable with a literal regex can be used where a literal regex is required.All of the
ArgumentList::*functions were updated to useExpr::resolve_constantwhere approriate, so they can also resolve literal variables (and any other improvements that may come with theresolve_constfunction in the future).There was also an internal refactor for the
resolve_constantfunction. TheTypeStateis the "source of truth" for compile-time information, including variables with known values. TheVariableexpression also included this. This was removed and now theTypeStateis always used.