-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a Community ID Function to the stdlib #360
Conversation
Thank you @owen5mith for this PR! I will do a detailed review shortly but to answer your question about benchmarks, can you try:
Adding it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@owen5mith: Thank you for submitting this PR!
This mostly looks good.I left some minor comments but most importantly some tests are failing. I will review again as soon as they are fixed.
Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
Hi @owen5mith, we are almost there. In order to fix some failing workflows, can you
|
Hi @owen5mith, this looks good now! |
Thanks, let me know if I need to add anything else to get this merged! 😀 |
Thanks for this contribution @owen5mith ! |
This PR addresses #359 by adding a Community ID Function. This is my first time writing Rust, so sorry in advance! 😄
One question I did have was around benchmarks. I have seen the
benches/stdlib.rs
file, should I be adding this function to those benchmarks, and if so, how do I get them to run? I've tried variouscargo bench
commands but have not managed to get any of the stdlib benchmarks to execute.