Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two bugs with exporting paths #679

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Feb 6, 2024

This series fixes handling exporting owned paths containing more than one coalesce segment, stemming from a mutable variable not being reset in a loop.

@bruceg bruceg added the type: bug A code related bug label Feb 6, 2024
@bruceg bruceg requested review from jszwedko and pront February 6, 2024 19:02
Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, can you share how ran the proptests?

@bruceg bruceg added this pull request to the merge queue Feb 6, 2024
@bruceg
Copy link
Member Author

bruceg commented Feb 6, 2024

Neat, can you share how ran the proptests?

For sure, that's coming up next.

Merged via the queue into main with commit 4624add Feb 6, 2024
11 checks passed
@bruceg bruceg deleted the bruceg/fix-exporting-paths branch February 6, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A code related bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants