chore!: Drop support for coalesce paths #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruceg
force-pushed
the
bruceg/remove-coalesce-path-support
branch
from
f890fe2
to
514dbee
Compare
bruceg
force-pushed
the
bruceg/remove-coalesce-path-support
branch
from
514dbee
to
1830865
Compare
pront
reviewed
May 10, 2024
| self.index += 1; | ||
| } | ||
| output | ||
| self.0.next().map(BorrowedSegment::from) |
jszwedko
approved these changes
May 20, 2024
|
Agreed, I don't think we need to wait. |
pront
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #678
Do we want to merge this already or wait until closer to cutting the next release?