Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: allow overriding rpc and pub/sub labels #87

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

VDanielEdwards
Copy link
Member

@VDanielEdwards VDanielEdwards commented Jul 29, 2024

Subject

This PR implements an extension to the participant configuration that allows to override the labels of DataPublisher, DataSubscriber, RpcClient, and RpcServer controllers in the participant configuration.

The format (all other controllers analogous) is like this:

RpcClients:
  - Name: MyRpcController
    Labels:
      - Key: SomeKey
        Value: SomeValue
        Kind: Mandatory
      - Key: AnotherKey
        Value: AnotherValue
        Kind: Optional

The labels completely replace what is specified in the code.

This is just a proposal to play around with, it is not neccessarily the final form.

JIRA Issue SILKIT-1636

Instructions for review / testing

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 29, 2024 11:03 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 29, 2024 11:03 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 29, 2024 11:03 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 29, 2024 11:03 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 29, 2024 11:03 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 29, 2024 11:03 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 29, 2024 11:03 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards self-assigned this Oct 29, 2024
@VDanielEdwards VDanielEdwards marked this pull request as ready for review October 29, 2024 07:10
Copy link
Contributor

@KonradBkd KonradBkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only some minor stuff, see the comments

@VDanielEdwards VDanielEdwards merged commit 7e7ae71 into main Oct 31, 2024
13 checks passed
@VDanielEdwards VDanielEdwards deleted the dev_config_pubsub_labels branch October 31, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants