-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: allow overriding rpc and pub/sub labels #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VDanielEdwards
temporarily deployed
to
public-github-runners
July 29, 2024 11:03
— with
GitHub Actions
Inactive
VDanielEdwards
temporarily deployed
to
public-github-runners
July 29, 2024 11:03
— with
GitHub Actions
Inactive
VDanielEdwards
temporarily deployed
to
public-github-runners
July 29, 2024 11:03
— with
GitHub Actions
Inactive
VDanielEdwards
temporarily deployed
to
public-github-runners
July 29, 2024 11:03
— with
GitHub Actions
Inactive
VDanielEdwards
temporarily deployed
to
public-github-runners
July 29, 2024 11:03
— with
GitHub Actions
Inactive
VDanielEdwards
temporarily deployed
to
public-github-runners
July 29, 2024 11:03
— with
GitHub Actions
Inactive
VDanielEdwards
temporarily deployed
to
public-github-runners
July 29, 2024 11:03
— with
GitHub Actions
Inactive
VDanielEdwards
force-pushed
the
dev_config_pubsub_labels
branch
from
October 29, 2024 07:18
aaa8432
to
9b8506b
Compare
KonradBkd
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only some minor stuff, see the comments
Co-authored-by: KonradBkd <117755498+KonradBkd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This PR implements an extension to the participant configuration that allows to override the labels of
DataPublisher
,DataSubscriber
,RpcClient
, andRpcServer
controllers in the participant configuration.The format (all other controllers analogous) is like this:
The labels completely replace what is specified in the code.
This is just a proposal to play around with, it is not neccessarily the final form.
JIRA Issue SILKIT-1636
Instructions for review / testing
Developer checklist (address before review)