Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: add vendored linux package option #88

Merged
merged 1 commit into from
Jul 30, 2024
Merged

cmake: add vendored linux package option #88

merged 1 commit into from
Jul 30, 2024

Conversation

VJanKraemer
Copy link
Contributor

Subject

Changes necessary to build a .deb package using upstream/vendored dependencies instead of the system libraries.

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 06:34 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 06:34 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 06:34 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 06:34 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 06:34 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 06:34 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 06:34 — with GitHub Actions Inactive
VDanielEdwards
VDanielEdwards reviewed Jul 30, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
VDanielEdwards
VDanielEdwards reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@VDanielEdwards VDanielEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would favor removing the override altogether over adding another option that turns the override off.

@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 08:20 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 08:20 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 08:20 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 08:20 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 08:20 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 08:20 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 08:20 — with GitHub Actions Inactive
VDanielEdwards
VDanielEdwards approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@VDanielEdwards VDanielEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@VJanKraemer
cmake: don't default to system libs for linux pkgs
7023f81 
Only use SILKIT_USE_SYSTEM_LIBRARIES when explicitly set by the user via
a CMake option!

Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 12:52 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 12:52 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 12:52 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 12:52 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 12:52 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 12:52 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer temporarily deployed to public-github-runners July 30, 2024 12:52 — with GitHub Actions Inactive
@VJanKraemer VJanKraemer merged commit 90755be into main Jul 30, 2024
10 checks passed
@VJanKraemer VJanKraemer deleted the refactor_cmake_linux branch July 30, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VDanielEdwards VDanielEdwards VDanielEdwards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VJanKraemer @VDanielEdwards