Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop CICD #28

Merged
merged 74 commits into from
Dec 29, 2023
Merged

Develop CICD #28

merged 74 commits into from
Dec 29, 2023

Conversation

vectornguyen76
Copy link
Owner

CICD workflow:

  • Install dependencies (caches)
  • Run isort
  • Run black
  • Run flake8
  • Build images (caches)
  • Push images to Docker Hub
  • Create infrastructure
  • Configure infrastructure
  • Deploy application using Docker Compose
  • Clean up following the concept of A/B deploy

Copy link

gitguardian bot commented Dec 29, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Base64 AWS keys 0fa55fb kubernetes/helm-charts/triton-inference-server/values.yaml View secret
- Base64 AWS keys 595582a kubernetes/helm-charts/triton-inference-server/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@vectornguyen76 vectornguyen76 merged commit 7b62634 into staging Dec 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant