Duplicated include; improved shutdown.c; store data even without switch #624
Conversation
…witch; commands.c: delete duplicated "mc_interface.h" include shutdown.c/shutdown.h/main.c: - reducing possibility to write backup data frequently, now requires minimum distance to be traveled before it enables storing, common condition if push to start is enabled with a low shutdown time, say 10s, or in any other condition where user turn on/off ESC a lot of times. Saves chip life at the cost of not having updated data during very short trips. - Data is stored even when using "always on" - Introducing possibility to store data without a power-switch by using a combination of trip distance and inactivity timer. It can be deactivated by using "always off" in app setting Shutdown Mode.
Gabrielerusso
changed the title
|
Tested in those weeks with 4 escs and different configuration, 2 with power switch and 2 without, now i was able to save data, like the odometer without problems even in the version without the power switch. |
| @@ -67,7 +68,11 @@ void shutdown_set_sampling_disabled(bool disabled) { | |||
| } | |||
|
|
|||
| static bool do_shutdown(void) { | |||
| conf_general_store_backup_data(); | |||
| // Store data if 1000m or more have been done to possibly reduce flash | |||
There was a problem hiding this comment.
I think it is safe to assume that writing the backup date is fine when a shutdown is triggered. Otherwise a lot of odometer data can remain unlogged.
There was a problem hiding this comment.
the amount of possible odometer data unlogged can be reduced by the distance, even 1m could be used even if it's pretty useless as not even car odometers have such accuracy, say one could set 10m or 100m.
Anyway it was just a suggestion as we don't use external eeprom like in automotive odometers.
STM32F405 flash endurance is >= 10k erase, those are not much compared to an eeprom with > 10^6 erase.
|
Please merge this. This also solves my #638 problem, as the only reason I need it is to store odometer data without software shutdown. |
commands.c:
shutdown.c / shutdown.h / main.c:
Compiled almost all version without issues, tested on my custom esc with different combinations (with power switch, without power switch) and it seems to work well.