Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add salt #275

Merged
merged 1 commit into from
Apr 14, 2018
Merged

add salt #275

merged 1 commit into from
Apr 14, 2018

Conversation

icyleaf
Copy link
Contributor

@icyleaf icyleaf commented Apr 10, 2018

Hi @veelenga.

I'am working a new wheel, heavy inspired by rack. for now most basic middleware was done.

RX14
RX14 approved these changes Apr 10, 2018
View reviewed changes
Copy link
Collaborator

@RX14 RX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should really accept tuples instead of arrays for return types though.

@icyleaf icyleaf mentioned this pull request Apr 11, 2018
Closed
@icyleaf
Copy link
Contributor Author

icyleaf commented Apr 12, 2018

done with tuples.

@RX14 RX14 merged commit de5c9c3 into veelenga:master Apr 14, 2018
@icyleaf icyleaf deleted the add-salt branch April 15, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@veelenga veelenga veelenga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icyleaf @RX14 @veelenga