Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some maintenance things #75

Closed
wants to merge 6 commits into from
Closed

Fix some maintenance things #75

wants to merge 6 commits into from

Conversation

hasezoey
Copy link
Contributor

@hasezoey hasezoey commented May 4, 2024

Description

This PR does some maintenance things, which include:

  • switch from the deprecated actions-rs scripts to more modern ones for the CI
  • explicitly set & Test the MSRV (currently being 1.74), also test rust nightly (also see this matrix)
  • be slightly more explicit in dependency version ranges (lib.rs suggestion)
  • remove remaining implicit features

The last change remove remaining implicit features could be seen as a breaking change

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have introduced no new C-bindings
  • The changes I've made are Windows, MacOS, UNIX, Linux compatible (or I've handled them using cfg target_os)
  • I increased or maintained the code coverage for the project, compared to the previous commit

@hasezoey
chore(workflows): change to not use "actions-rs"
9a0ca42 
instead use "dtolnay/rust-toolchain" and direct cargo commands
@hasezoey
chore: set MSRV and test it
f7f6203
@hasezoey
chore: dont ignore "Cargo.lock" for consistent CI and development
32169b3
@hasezoey
chore(Cargo.toml): be a little more specific in dependency versions
7af8569 
re lib.rs suggestion:
Cargo does not always pick latest versions of dependencies! Specify the version as lazy-regex = "3.1.0". If Cargo.lock ends up having an unexpectedly old version of the dependency, you might get a dependency that lacks features/APIs or important bugfixes that you depend on. This is most likely to happen when using the minimal-versions flag, used by users of old Rust versions.
@hasezoey
chore(Cargo.toml): no implicit features
8f7ff2b
@hasezoey
docs(CHANGELOG): add entries for this PR
2a13266 
for
- 8f7ff2b
- 7af8569
- f7f6203
@hasezoey hasezoey changed the title Fix some general things Fix some maintenance things May 4, 2024
@veeso veeso closed this Oct 13, 2024
@veeso
Copy link
Owner

veeso commented Oct 13, 2024

no more necessary. Already fixed

@hasezoey hasezoey deleted the fixGeneral branch October 13, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasezoey @veeso