Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add integers to four digit year format example #3218

Merged
merged 4 commits into from
Oct 7, 2023

Conversation

ChiaLingWeng
Copy link
Contributor

@ChiaLingWeng ChiaLingWeng commented Oct 6, 2023

This will close #3162 .
Add an example as below comparing using quantitative, ordinal and temporal data type.
image

With explanation:
To plot the year data as four digit format; i.e. without thousand separator, we recommend converting integer to string data type first, then storing the data as temporal, since directly convert integer to temporal data type would result in an error.

And also close #1365
image

@joelostblom joelostblom self-requested a review October 7, 2023 15:30
@joelostblom joelostblom self-assigned this Oct 7, 2023
@joelostblom
Copy link
Contributor

Thanks for this @ChiaLingWeng ! I made some modifications directly to the PR and will go ahead and merge.

@joelostblom joelostblom merged commit ef4b86e into vega:main Oct 7, 2023
10 checks passed
@ChiaLingWeng ChiaLingWeng deleted the dev branch October 16, 2023 00:00
@ChiaLingWeng ChiaLingWeng restored the dev branch October 30, 2023 01:56
@ChiaLingWeng ChiaLingWeng deleted the dev branch October 30, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better deal with year integer? Add an example of reading in years in a convenient manner
2 participants