Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zoom/pan scale binding for geo data #8856

Closed
jwoLondon opened this issue Apr 21, 2023 · 5 comments
Closed

Allow zoom/pan scale binding for geo data #8856

jwoLondon opened this issue Apr 21, 2023 · 5 comments

Comments

@jwoLondon
Copy link
Contributor

Great to see the ability to use interval selections with geoData with the VL5.7 release. This makes brushing between geographic and non-geographic views a possibility, which is something I've wanted for a long time. Thank you.

Does this make the possibility of a bind scales option for longitude/latitude data a viable prospect? It would be great to allow zooming and panning of geodata (which often benefit from zooming more than many other data types) via an interval selection so that we don't have to rely on range sliders to control projection parameters.

It wouldn't need any change to the API as it could use exactly the same API as used for cartesian positioning (which currently generates the error Cannot read properties of undefined (reading 'on') [Warning] Scale bindings are currently only supported for scales with unbinned, continuous domains. when used with longitude/latitude projected data)

@joelostblom
Copy link
Contributor

I think this would be super useful too! I noticed that there is an ongoing discussion about panning and zooming in #3306 so I went ahead and renamed that issue accordingly. I will close this one as a duplicate, so feel free to add to the discussion in #3306 instead.

@joshuahhh
Copy link

Heads-up @joelostblom – There's a way to mark an issue on GitHub as a duplicate, rather than closing it as completed: https://docs.github.com/en/issues/tracking-your-work-with-issues/marking-issues-or-pull-requests-as-a-duplicate. I think it would be better to use that, since it's a bit confusing to see "closed this as completed" in the log here. Thanks!

@joelostblom joelostblom reopened this May 28, 2024
@joelostblom
Copy link
Contributor

joelostblom commented May 28, 2024

Duplicate of #3306

@joelostblom joelostblom marked this as a duplicate of #3306 May 28, 2024
@joelostblom
Copy link
Contributor

Oh, I didn't know of that functionality. It's handy to have as a saved reply, thanks!

@joelostblom joelostblom closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
@domoritz
Copy link
Member

Didn't know either. Will save that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants