Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export timeunit.format() for VgTooltip #1240

Merged
merged 1 commit into from
Apr 1, 2016
Merged

Conversation

light-and-salt
Copy link
Contributor

Export timeunit.format(timeUnit, abbreviated) because tooltip needs to translate VL timeUnit to the time string specifier.

@domoritz
Copy link
Member

Do we have to move the function? It's very inconsistent now.

@kanitw
Copy link
Member

kanitw commented Mar 24, 2016

@domoritz what's inconsistent? (Ideally we shouldn't expose methods inside compile to the public?)

@domoritz
Copy link
Member

What's inconsistent is that other methods stayed in time.ts (https://github.com/vega/vega-lite/blob/zqu/export-format/src/compile/time.ts). What's different about format? Is it the fact that it is made available to the outside? I don't have strong opinions just try to understand the reasoning.

@light-and-salt light-and-salt merged commit 68e0c1a into master Apr 1, 2016
@domoritz domoritz deleted the zqu/export-format branch April 2, 2016 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants