Axis properties #1290
Merged
Axis properties #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -195,6 +195,14 @@ export function tickSize(model: Model, channel: Channel) { | |||
| return undefined; | |||
| } | |||
|
|
|||
| export function tickSizeEnd(model: Model, channel: Channel) { | |||
There was a problem hiding this comment.
You still haven't modified the top of this file (line 86) as suggested earlier.
| return labelsSpec || undefined; | ||
| } | ||
|
|
||
| export function ticks(model: Model, channel: Channel, ticksPropsSpec, def) { |
There was a problem hiding this comment.
let's remove def from all of these methods if it's not used. (If it's used like labels(), we can leave it in.)
|
did I press some wrong buttons? why is it closed? |
|
All the properties are tested in editor |
This was referenced Apr 20, 2016
|
LGTM. One last thing. Can you add documentation for these added properties? |
|
Documentation added |
| @@ -249,7 +249,7 @@ vg.embed('#horizontal_line', { | |||
| | Property | Type | Description | | |||
| | :------------------ |:-------------------:| :------------| | |||
| | font | String | The typeface to set the text in (e.g., `Helvetica Neue`).| | |||
| | fontSize | Number | The font size, in pixels. The default value is 10. | | |||
| | fontSize | Number | The font size, in pixels. The default value is 10. | | |||
There was a problem hiding this comment.
why are there whitespace in the front of this line?
There was a problem hiding this comment.
Sorry that is a typo, just fixed it.
|
🎉 |
willium
added a commit
that referenced
this pull request
May 10, 2016
* master: Update integrations.md Add new legend properties (#1302) Axis properties (#1290) add documentation (#1334) Tick mark orient inverted (#1293) Size support stack (#1312) Make CellConfig.strokeDash an array Remove example with log scale that is not meant to be a showcase Correct a typo in size scales description (#1308) Add tickSizeRange fixing #1298 (#1299)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support more properties for axis