fix bug tick orient inverted #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,7 +42,12 @@ describe('Mark: Bar', function() { | |||
| "y": {"bin": true, "type": "quantitative", "field": "IMDB_Rating"}, | |||
| "x": {"scale": {"type": 'log'}, "type": "quantitative", "field": 'US_Gross', "aggregate": "mean"} | |||
| }, | |||
| "data": {"url": 'data/movies.json'} | |||
| "data": {"url": 'data/movies.json'}, | |||
There was a problem hiding this comment.
You're fixing default behavior in config.ts, but here modify the test to no longer test the default behavior. The correct fix is to fix the asserts below.
|
Can you provide a screenshot as well? |
|
Fix the test. |
| assert.deepEqual(props.x2, {scale: 'x', value: 0}); | ||
| }); | ||
|
|
||
| it('should have no width', function(){ |
There was a problem hiding this comment.
should have no height too? Why did you just remove it?
|
reset the default orient for tick along with tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1347
Bug is the default orient should be vertical, instead of horizontal.
Now this spec will give the following output correctly.