Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also filter NaN values #1416

Merged
merged 1 commit into from
Jun 10, 2016
Merged

Also filter NaN values #1416

merged 1 commit into from
Jun 10, 2016

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Jun 7, 2016

Fix #1411

Question

  • Should we only filter this for date field?
  • Should we rename filterNull to filterInvalidValues since it's no longer just null?

Now temporal line chart sorts correctly!

vega_editor

@kanitw
Copy link
Member Author

kanitw commented Jun 10, 2016

I'll merge this for now. We can further discuss in #1426

@kanitw kanitw merged commit b32f03c into master Jun 10, 2016
@kanitw kanitw deleted the kw/fix-NaN branch June 10, 2016 21:53
@kanitw kanitw mentioned this pull request Jul 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@domoritz domoritz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanitw @domoritz