Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getFilterExpression method from src/compile/data/filter.ts to src/filter.ts as expression #1498

Merged
merged 3 commits into from
Aug 11, 2016
Merged

Move getFilterExpression method from src/compile/data/filter.ts to src/filter.ts as expression #1498

merged 3 commits into from
Aug 11, 2016

Conversation

espressoroaster
Copy link
Member

Fix #1491

  • Move src/compile/data/filter.ts's getFilterExpression to be expresssion in src/filter.ts
  • Move src/compile/data/filter.ts's valueExpr to src/filter.ts (method is required by expression)

@espressoroaster espressoroaster changed the title Fo/1491 move get filter expression [WIP] Aug 11, 2016
@espressoroaster espressoroaster changed the title [WIP] Move getFilterExpression from src/compile/data/filter.ts to be expression in src/filter.ts Aug 11, 2016
@espressoroaster espressoroaster changed the title Move getFilterExpression from src/compile/data/filter.ts to be expression in src/filter.ts Move getFilterExpression method from src/compile/data/filter.ts to src/filter.ts as expression Aug 11, 2016
@kanitw kanitw merged commit 345f7de into master Aug 11, 2016
@kanitw kanitw deleted the fo/1491-move-getFilterExpression branch August 11, 2016 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@espressoroaster @kanitw