Support conditional encoding #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, thank you for this! Gonna make my life much easier. |
kanitw
force-pushed
the
kw/condition
branch
5 times, most recently
from
411d643
to
b7337d1
Compare
This was referenced Feb 21, 2017
Closed
arvind
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Merge #1970 first)
@arvind I just added scaffolding code for generating a Vega production rule from our conditional encoding syntax.
I'll let you take over and add code for how to generate
"test"property for selection.Since we no longer have to deal with how it interacts with transform, I think we're pretty close to have selection really working!