Fix schema for config.invalidValues
#3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
commented
Dec 19, 2017
| "type": "string" | ||
| "type": [ | ||
| "string", | ||
| "null" |
There was a problem hiding this comment.
@domoritz The schema generator actually still generate incorrect results here.
(The enum property should include null above -- otherwise, JSON schema validator would still throw warning.)
There was a problem hiding this comment.
Hmm, so you want it to be
enum: "filter", null
type: string
?
There was a problem hiding this comment.
I think it should be
enum: ["filter", null]
type: ["string", "null"]
There was a problem hiding this comment.
https://spacetelescope.github.io/understanding-json-schema/reference/null.html isn't clear about this but it seems that you are right: json-schema-org/json-schema-spec#258. We do need to add the type and also add null to the enum.
Filed in vega/ts-json-schema-generator#22
There was a problem hiding this comment.
Fixed. I added a commit with the new schema.
… needed when we specify | null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3234