Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable interval selections for cartographic projections #6953

Merged
merged 17 commits into from
Feb 24, 2023
Merged

feat: enable interval selections for cartographic projections #6953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ec8176f
Initial work to support geo-interval selections.
arvind Oct 10, 2020
7791c54
Preliminary geo intervals init.
arvind Jan 5, 2021
f328e77
Update existing compile-time tests
arvind Apr 28, 2022
f036dae
Mark geoshapes as interactive if there are selections present in
arvind Apr 28, 2022
3005ad7
Add compile-time tests for geo-interval signals
arvind Apr 28, 2022
636dc88
For non-cartesian groups, set a 'view' style (vega/vega#3480) for a t…
arvind Apr 28, 2022
bfea6fc
Use projection center to init 1D geo intervals
arvind Apr 29, 2022
690b35e
Initialize geo intervals with a timer signal
arvind Apr 29, 2022
4a491f6
Update compile-time tests
arvind Apr 29, 2022
a4a12fe
chore: update TOC [CI]
Apr 29, 2022
9f44f6d
chore: update examples [CI]
Apr 29, 2022
3db5481
Add interactive geo brush examples
arvind Apr 29, 2022
bda058e
fix: prevent selection compilers from side effecting selection defs
arvind Apr 29, 2022
b837c81
fix: don't fire geo-brush intersection on unit signal updates
arvind Jun 13, 2022
51fc546
chore: update TOC [CI]
Jun 13, 2022
444301c
chore: update examples [CI]
Jun 13, 2022
50ab21f
Update runtime tests
arvind Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/compiled/airport_connections.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion examples/compiled/airport_connections.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"padding": 5,
"width": 900,
"height": 500,
"style": "view",
"data": [
{"name": "org_store"},
{
Expand Down Expand Up @@ -177,7 +178,7 @@
"name": "layer_0_marks",
"type": "shape",
"style": ["geoshape"],
"interactive": false,
"interactive": true,
"from": {"data": "source_0"},
"encode": {
"update": {
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/arc_donut.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/arc_facet.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
{
"name": "cell",
"type": "group",
"style": "view",
"from": {
"facet": {"name": "facet", "data": "source_0", "groupby": ["year"]}
},
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/arc_ordinal_theta.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
2 changes: 2 additions & 0 deletions examples/compiled/arc_params.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
"type": "group",
"name": "concat_0_group",
"title": {"text": "Single Arc", "frame": "group"},
"style": "view",
"encode": {
"update": {
"width": {"signal": "childWidth"},
Expand Down Expand Up @@ -114,6 +115,7 @@
"type": "group",
"name": "concat_1_group",
"title": {"text": "Stacked Arcs", "frame": "group"},
"style": "view",
"encode": {
"update": {
"width": {"signal": "childWidth"},
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/arc_pie.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/arc_pie_pyramid.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/arc_radial.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "view",
"data": [
{"name": "source_0", "values": [12, 23, 47, 6, 52, 19]},
{
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/arc_radial_histogram.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_choropleth.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "view",
"data": [
{
"name": "source_1",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_circle.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_constant_value.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "view",
"data": [
{"name": "source_0", "url": "data/airports.csv", "format": {"type": "csv"}},
{
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_custom_projection.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 900,
"height": 560,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_graticule.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "view",
"data": [{"name": "source_0", "transform": [{"type": "graticule"}]}],
"projections": [
{
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_graticule_object.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "view",
"data": [
{"name": "source_0", "transform": [{"type": "graticule", "step": [15, 15]}]}
],
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_layer.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_layer_line_london.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 700,
"height": 500,
"style": "view",
"encode": {"update": {"stroke": {"value": "transparent"}}},
"data": [
{
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_line.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"padding": 5,
"width": 800,
"height": 500,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_params_projections.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_point.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
3 changes: 3 additions & 0 deletions examples/compiled/geo_repeat.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
{
"type": "group",
"name": "child__row_population_group",
"style": "view",
"encode": {
"update": {
"width": {"signal": "width"},
Expand Down Expand Up @@ -145,6 +146,7 @@
{
"type": "group",
"name": "child__row_engineers_group",
"style": "view",
"encode": {
"update": {
"width": {"signal": "width"},
Expand Down Expand Up @@ -189,6 +191,7 @@
{
"type": "group",
"name": "child__row_hurricanes_group",
"style": "view",
"encode": {
"update": {
"width": {"signal": "width"},
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_rule.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 800,
"height": 500,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_sphere.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "view",
"data": [
{"name": "source_0", "values": [{"type": "Sphere"}]},
{"name": "source_1", "transform": [{"type": "graticule"}]}
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_text.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"padding": 5,
"width": 800,
"height": 500,
"style": "view",
"data": [
{
"name": "source_0",
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/geo_trellis.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
{
"name": "cell",
"type": "group",
"style": "view",
"from": {
"facet": {"name": "facet", "data": "source_0", "groupby": ["group"]}
},
Expand Down
Binary file added examples/compiled/interactive_1d_geo_brush.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions examples/compiled/interactive_1d_geo_brush.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading