Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: tutorial references "temperature" when data is precipitation #8467

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

rgkirch
Copy link
Contributor

@rgkirch rgkirch commented Oct 10, 2022

Please:

  • Make the pull requests (PRs) atomic (fix one issue at a time). Multiple relevant issues that must be fixed together? Make atomic commits so we can easily review each issue.
  • Provide a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties") so we can easily copy it to the release note.
    • Use imperative mood and present tense.
  • Mention relevant issues in the description (e.g., Fixes #1 / Fixes part of #1).
  • Lint and test (Run yarn test).
  • Review your changes before sending the PR (to ensure code quality).
  • For new features:
    • Add new unit tests.
    • Update the documentation under site/docs/ + add examples.

Tips:

@domoritz
Copy link
Member

Can you please use semantic messages for the pull request title and include some more details about the change (like a screenshot of the current page)?

@rgkirch
Copy link
Contributor Author

rgkirch commented Oct 11, 2022

image

@rgkirch rgkirch changed the title Update explore.md tutorial references "temperature" when data is precipitation Oct 11, 2022
@domoritz domoritz changed the title tutorial references "temperature" when data is precipitation docs: tutorial references "temperature" when data is precipitation Oct 11, 2022
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@domoritz domoritz merged commit d8ed58e into vega:next Feb 12, 2023
@vega-org-bot
Copy link
Collaborator

🚀 PR was released in v5.7.0-next.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants