Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly calculate total width/height and offset for trellis plot #880

Merged
merged 2 commits into from
Dec 18, 2015
Merged

Correctly calculate total width/height and offset for trellis plot #880

merged 2 commits into from
Dec 18, 2015

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Dec 18, 2015

  • Total Width Height should be (cellWidth|Height + cellPadding) * cardinality instead of (cellWidth|Height + cellPadding) * cardinality - cellPadding
  • avoid negative offset in trellis’s subgroups, which makes the group not start from (0,0)

fixes #828

@kanitw kanitw mentioned this pull request Dec 18, 2015
Closed
domoritz added a commit that referenced this pull request Dec 18, 2015
@domoritz
Merge pull request #880 from vega/kw/828
b1c8cf4 
Correctly calculate total width/height and offset for trellis plot
@domoritz domoritz merged commit b1c8cf4 into master Dec 18, 2015
@domoritz domoritz deleted the kw/828 branch December 18, 2015 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@domoritz domoritz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Axis position incorrect for small multiples with one multiple
2 participants
@kanitw @domoritz