Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor marks.ts and legend.ts #913

Merged
merged 13 commits into from
Jan 11, 2016
Merged

refactor marks.ts and legend.ts #913

merged 13 commits into from
Jan 11, 2016

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Jan 11, 2016

Mark Config

  • add fill, fillOpacity, stroke, and strokeOpacity

marks.ts

  • add ColorMode
  • refactor colorMixins to applyColorAndOpacity
    • apply fill and stroke config for all marks

legend.ts

  • apply fill and stroke config

@kanitw kanitw changed the title refactor marks.ts's colorMixins refactor marks.ts Jan 11, 2016
@kanitw kanitw changed the title refactor marks.ts refactor marks.ts and legend.ts Jan 11, 2016
@kanitw
- add fillOpacity, strokeOpacity
d77ac66 
- remove complicated opacity rules (which apply opacity to either fillOpacity/strokeOpacity) -- now opacity is mapped to opacity
domoritz added a commit that referenced this pull request Jan 11, 2016
@domoritz
Merge pull request #913 from vega/kw/alwaysFilled
eed49fa 
refactor marks.ts and legend.ts
@domoritz domoritz merged commit eed49fa into master Jan 11, 2016
@domoritz domoritz deleted the kw/alwaysFilled branch January 11, 2016 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@domoritz domoritz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanitw @domoritz